Thread (15 messages) flat view 15 messages, 2 authors, 2014-12-08

[STLinux Kernel] [PATCH v2 RESEND 02/11] mtd: st_spi_fsm: Obtain and use EMI clock if provided

From: peter.griffin@linaro.org (Peter Griffin)
Date: 2014-12-08 13:57:23
Also in: lkml

Hi Lee,
On Thu, 04 Dec 2014, Lee Jones wrote:
quoted
ST's Common Clk Framework is now available. This patch ensures the FSM
makes use of it by obtaining and enabling the EMI clock if provided. If
system fails to provide the EMI clock FSM uses its original default
rate.
<snip>

I'm not sure I understand this patch. Now that common clock framework
is available for STI platforms, why would the emi clock ever not be available?

If it is to maintain DT compatability then we are already breaking this with the
syscfg 'reg' DT changes which are coming up, and this was deemed OK as the platform
is WIP.

IMO keeping this legacy code which assumes the bootloader / JTAG has enabled and configured
the emi clock correctly is not worth it now that CCF is available for the platform.
Also this legacy code will definately break when we we stop booting the kernel with
"clk_ignore_unused" parameter.

regards,

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help