Thread (28 messages) 28 messages, 7 authors, 2015-03-13

[PATCH v3 1/3] devicetree: of: Add bindings for chosennode, stdout-path

From: Grant Likely <hidden>
Date: 2014-12-04 10:39:25
Also in: linux-devicetree, lkml

On Wed, 03 Dec 2014 15:07:49 -0800
, Frank Rowand [off-list ref]
 wrote:
On 12/3/2014 1:45 PM, Grant Likely wrote:
quoted
On Wed, Dec 3, 2014 at 7:46 PM, Frank Rowand [off-list ref] wrote:
quoted
On 12/3/2014 7:12 AM, Grant Likely wrote:
quoted
On Wed, Dec 3, 2014 at 2:24 AM, Frank Rowand [off-list ref] wrote:
quoted
On 11/27/2014 9:56 AM, Leif Lindholm wrote:
quoted
Add a global binding for the chosen node.
Include a description of the stdout-path, and an explicit statement on
its extra options in the context of a UART console.

Opening description stolen from www.devicetree.org, and part of the
remaining text provided by Mark Rutland.

Signed-off-by: Leif Lindholm <redacted>
---
 Documentation/devicetree/bindings/chosen.txt |   42 ++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/chosen.txt
diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt
new file mode 100644
index 0000000..9cd74e9
--- /dev/null
+++ b/Documentation/devicetree/bindings/chosen.txt
@@ -0,0 +1,42 @@
+The chosen node
+---------------
+
+The chosen node does not represent a real device, but serves as a place
+for passing data between firmware and the operating system, like boot
+arguments. Data in the chosen node does not represent the hardware.
+
+
+stdout-path property
The code in patch 3/3 adds the extra options feature to the properties:

  stdout-path
  linux,stdout-path
  stdout  [if (IS_ENABLED(CONFIG_PPC) ... ]
I don't understand what you mean here. Are you suggesting a change to
this patch? Is there something deficient in it?
Assuming that the code change in patch 3 is as desired, then the chosen.txt
documentation applies to all three properties, not just stdout-path.  So
yes, a change is suggested for the documentation.
how about if this is added:

Implementation note: Linux will look for the property "linux,stdout-path" or
on PowerPC "stdout" if "stdout-path" is not found.  However, the
"linux,stdout-path" and "stdout" properties are deprecated. New platforms
should only use the "stdout-path" property.

g.
Yep, perfect.
Great, thanks. Merged.

g.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help