[PATCH v5 3/6] arm64: Add framework for legacy instruction emulation

On Mon, Nov 24, 2014 at 08:58:33PM +0000, Greg Hackmann wrote:

If it's not too late to chime in, I ran across one issue testing this patchset:

On Tue, Nov 18, 2014 at 3:41 AM, Punit Agrawal [off-list ref] wrote:

quoted

+       ret = update_insn_emulation_mode(insn, prev_mode);
+       if (!ret) {
+               /* Mode change failed, revert to previous mode. */
+               insn->current_mode = prev_mode;
+               update_insn_emulation_mode(insn, INSN_UNDEF);
+       }

update_insn_emulation_mode() returns 0 on success, so the condition
needs to be "if (ret)".  Otherwise writes to the sysctl file are
immediately rolled back.

Thanks Gene, I'll add that on top with your reported-by.

Will