Thread (1 message) 1 message, 1 author, 2014-11-14

[PATCHv4 1/5] arm64: Add support for hooks to handle undefined instructions

From: Punit Agrawal <hidden>
Date: 2014-11-14 17:39:25

Hi Catalin,

Catalin Marinas [off-list ref] writes:
On Wed, Nov 12, 2014 at 11:44:48AM +0000, Punit Agrawal wrote:
quoted
+int register_undef_hook(struct undef_hook *hook)
+{
+	unsigned long flags;
+
+	raw_spin_lock_irqsave(&undef_lock, flags);
+	list_add(&hook->node, &undef_hook);
+	raw_spin_unlock_irqrestore(&undef_lock, flags);
+
+	return 0;
+}
I missed this. Why do we need this function to return something? I don't
see how it would fail.
You're right. I don't remember why I changed the return type when
porting this over from arm. I'll update this and affected code.

Cheers,
Punit
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help