Thread (7 messages) flat view 7 messages, 4 authors, 2014-11-15
STALE4286d REVIEWED: 6 (6M)

1 review trailer.

[PATCH] PM / Domains: Change prototype for the ->attach_dev() callback

From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2014-11-06 07:36:20
Also in: linux-pm, linux-samsung-soc

Possibly related (same subject, not in this thread)

On Thu, Nov 6, 2014 at 12:11 AM, Kevin Hilman [off-list ref] wrote:
From: Ulf Hansson <redacted>
Date: Thu, 30 Oct 2014 13:02:49 +0100
Subject: [PATCH] PM / Domains: Change prototype for the attach and detach
 callbacks

Convert the prototypes to return an int in order to support error
handling in these callbacks.

Also, as suggested by Dmitry Torokhov, pass the domain pointer for use
inside the callbacks, and so that they match the existing
power_on/power_off callbacks which currently take the domain pointer.

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
[khilman: added domain as parameter to callbacks, as suggested by Dmitry]
OK, so back to the signature of the original version...
Signed-off-by: Ulf Hansson <redacted>
Signed-off-by: Kevin Hilman <redacted>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help