On Sat, Nov 22, 2014 at 3:39 PM, Julia Lawall [off-list ref] wrote:

From: Julia Lawall <redacted>

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <redacted>

Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij