Thread (22 messages) 22 messages, 2 authors, 2014-11-28

[PATCH v4 3/7] regulator: of: Parse ena-gpios property from DTS

From: Krzysztof Kozlowski <hidden>
Date: 2014-11-28 09:20:12
Also in: linux-devicetree, linux-samsung-soc, lkml

On czw, 2014-11-27 at 18:45 +0000, Mark Brown wrote:
On Thu, Nov 27, 2014 at 12:20:49PM +0100, Krzysztof Kozlowski wrote:
quoted
+	constraints->ena_gpio = of_get_named_gpio_flags(np, "ena-gpios", 0,
+							&gpio_flags);
+	if (gpio_is_valid(constraints->ena_gpio)) {
No, this isn't sensible - in what way would an enable control GPIO be a
constraint?  The whole reason we have separate constraint and config
structures is that these are different things.  Keep the GPIO setup in
the configuration.
OK, I'll change it to config.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help