[PATCH 3.18-rc4 v11 2/6] irqchip: gic: Optimize locking in gic_raise_softirq
From: Thomas Gleixner <hidden>
Date: 2014-11-27 21:37:52
Also in:
lkml
From: Thomas Gleixner <hidden>
Date: 2014-11-27 21:37:52
Also in:
lkml
On Thu, 27 Nov 2014, Daniel Thompson wrote:
Currently gic_raise_softirq() unconditionally takes and releases a lock whose only purpose is to synchronize with the b.L switcher. Remove this lock if the b.L switcher is not compiled in.
I think the patches are in the wrong order. We optimize for the sane use case first, i.e BL=n. So you want to make the locking of irq_controller_lock in gic_raise_softirq() conditional in the first place, which should have been done when this was introduced. Once you have isolated that you can apply your split lock patch for the BL=y nonsense. Adding more locks first and then optimizing them out does not make any sense. Thanks, tglx