Thread (11 messages) 11 messages, 3 authors, 2014-11-24

[PATCH v2 1/5] video: omapdss: Add opa362 driver

From: Tomi Valkeinen <hidden>
Date: 2014-11-24 11:48:56
Also in: linux-devicetree, linux-fbdev, linux-omap, lkml

On 19/11/14 17:10, Dr. H. Nikolaus Schaller wrote:
quoted
You don't need to ask. The connector calls invert_vid_out_polarity
before enabling the output.
Unfortunately it doesn?t. At least not always.

It does only for pdata systems but not for DT based systems:

	if (!ddata->dev->of_node) {
		in->ops.atv->set_type(in, ddata->connector_type);
		in->ops.atv->invert_vid_out_polarity(in,
			ddata->invert_polarity);
	}

Not calling is in our case different from calling with ddata->invert_polarity == 0.
Ah, sorry, my mistake. I should've read the code more carefully =).

So, with DT only approach, those calls above are not supported. If you
make the OPA driver DT only, you can remove those functions.

You only need to set the invert-polarity property in the venc DT node.

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141124/6701141c/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help