Thread (5 messages) 5 messages, 5 authors, 2014-11-28

[PATCH] serial: 8250_dw: Handle no_console_suspend when uart loses state

From: heiko@sntech.de (Heiko Stübner)
Date: 2014-11-17 09:17:15
Also in: linux-serial, lkml

Am Montag, 17. November 2014, 09:56:08 schrieb Loic Poulain:
quoted
In certain suspend modes on certain boards the 8250 UART may lose
state when the device goes to suspend.  If we're using
no_console_suspend this can cause lots of problems during resume.

Let's cache the basic UART config registers at suspend time and if we
notice that the UART loses state (by looking at a canary stored in the
scratch register) we'll restore it.
If I'm not wrong, it's already done in acpi_lpss suspend/resume (for
8250_dw).
Commit c78b0830667a7e7c1f0ca65b76b33166a84806b3.
It looks like it, but of course only takes into account devices probed via 
acpi, missing the devices probed via devicetree.

So it looks like we need Doug's solution somehow, question would be if it 
should be excluded on acpi platforms.


Heiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help