[PATCH v4 6/6] ARM: zynq: DT: Add OCM controller node
From: Sören Brinkmann <hidden>
Date: 2014-11-16 19:32:36
Also in:
linux-devicetree, lkml
From: Sören Brinkmann <hidden>
Date: 2014-11-16 19:32:36
Also in:
linux-devicetree, lkml
On Sun, 2014-11-16 at 11:51AM +0100, Andreas F?rber wrote:
Hi Michal, Am 14.11.2014 um 11:52 schrieb Michal Simek:quoted
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi index ce2ef5bec4f2..e217fb1c1169 100644 --- a/arch/arm/boot/dts/zynq-7000.dtsi +++ b/arch/arm/boot/dts/zynq-7000.dtsi@@ -150,6 +150,13 @@ reg = <0xf8006000 0x1000>; }; + ocmc: memory-controller at f800c000 { + compatible = "xlnx,zynq-ocmc-1.0"; + interrupt-parent = <&intc>; + interrupts = <0 3 4>; + reg = <0xf800c000 0x1000>; + }; + uart0: serial at e0000000 { compatible = "xlnx,xuartps", "cdns,uart-r1p8"; status = "disabled";Not directly related to this patch: As one can see here, the node order is quite a mess... According to Olof, nodes should be ordered by unit address, whereas here some but not all seem ordered by node name. Would you welcome a cleanup patch, or can you fix that yourself?
I wouldn't say it's a mess, just a different property to sort the nodes by. For humans reading the DT, searching for nodes, alphabetical order helps finding the right node, IMHO. What advantage would sorting by address have? Thanks, S?ren