Thread (22 messages) 22 messages, 3 authors, 2015-01-12

[PATCH v9 07/12] coresight-etm: add CoreSight ETM/PTM driver

From: Paul Bolle <hidden>
Date: 2014-11-10 19:32:15
Also in: lkml

On Mon, 2014-11-10 at 08:40 -0700, Mathieu Poirier wrote:
On 10 November 2014 03:34, Paul Bolle [off-list ref] wrote:
quoted
On Mon, 2014-11-03 at 11:07 -0700, mathieu.poirier at linaro.org wrote:
quoted
+#ifdef CONFIG_CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE
There's no Kconfig symbol CORESIGHT_SOURCE_ETM_DEFAULT_ENABLE. Neither
is there a preprocessor definition of this macro. So why was this
added?
Correct - the feature (as we really want it) is currently being worked
on but not yet part of the code base.  The default option probably
should have been removed but it doesn't do much else when mandating
one to add a boot option on the kernel cmd line.
I'm afraid I'm not sure what you mean here. Anyhow, using a Kconfig
symbol to set a default for something that can also be set through a
kernel parameter might be considered overdoing it. But that's not for me
to decide.

Unless the patch that adds this Kconfig symbol takes a long time to land
in linux-next, I won't be bothering you again.

Thanks,


Paul Bolle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help