On Thu, Nov 6, 2014 at 12:22 PM, Mika Westerberg
[off-list ref] wrote:

On Thu, Nov 06, 2014 at 12:12:04PM +0100, Geert Uytterhoeven wrote:

quoted

On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg
[off-list ref] wrote:

quoted

On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote:

quoted

On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg
[off-list ref] wrote:

quoted

quoted

"leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on
non-DT platforms for me:

    gpiod_direction_output: invalid GPIO
    leds-gpio: probe of leds-gpio failed with error -22

(desc is NULL in gpiod_direction_output()).

quoted

    leds-gpio leds-gpio: GPIO 102, ret: 0
    leds-gpio leds-gpio: GPIOD: c050e970

So led_dat is non-NULL. But it's overwritten by NULL later:

    led_dat->gpiod = template->gpiod;

Ah, that's it. Nice catch!

quoted

Whitespace damaged fix below, to fold into the original.
If you prefer a proper separate patch, let me know.

It is up to Rafael. I think he wants to stabilize this branch so in that
case separate patch on top would work better.

I've already sent a patch, as I have to publish the fix in my git tree anyway.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds