[PATCH 3/8] ARM: shmobile: r8a73a4: Add SCIF nodes
From: horms@verge.net.au (Simon Horman)
Date: 2014-10-31 04:54:08
Also in:
linux-sh
On Thu, Oct 30, 2014 at 06:43:12PM +0100, Ulrich Hecht wrote:
Hi! On Tue, Jul 15, 2014 at 11:16 AM, Simon Horman [off-list ref] wrote:quoted
This describes all of the SCIF hardware of the r8a73a4. Each node is disabled and may be enabled as necessary by board DTS files.[...]quoted
+ scifb2: serial at e6c20000 { + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; + reg = <0 0xe6c20000 0 0x100>; + interrupts = <0 148 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + scifb3: serial at e6c30000 { + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; + reg = <0 0xe6c30000 0 0x100>; + interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + scifb4: serial at e6ce0000 { + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; + reg = <0 0xe6ce0000 0 0x100>; + interrupts = <0 150 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + + scifb5: serial at e6cf0000 { + compatible = "renesas,scifb-r8a73a4", "renesas,scifb"; + reg = <0 0xe6cf0000 0 0x100>; + interrupts = <0 151 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; +I was just about to add clocks to these devices when I noticed that these ports are labeled scifb0 to scifb3 in the datasheet. Is there any deeper reasoning behind this, or did you just forget to reset the counter after scifa1? :)
Its a while since I wrote this patch. I think the reason is that I was blindly following the numbering-scheme used in r8a73a4. In any case, I think it would be good to name them according to the datasheet. Could you cook up a patch?