Thread (3 messages) 3 messages, 3 authors, 2014-10-30
STALE4249d

[PATCH 4/4] PM / Domains: Let the ->attach_dev() callback return an error code

From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2014-10-29 21:18:55
Also in: linux-pm, linux-samsung-soc

Hi Kevin,

On Wed, Oct 29, 2014 at 10:10 PM, Kevin Hilman [off-list ref] wrote:
Geert Uytterhoeven [off-list ref] writes:
quoted
On Tue, Oct 28, 2014 at 3:38 PM, Ulf Hansson [off-list ref] wrote:
quoted
Typically an ->attach_dev() callback would fetch some PM resourses.

Those operations, like for example clk_get() may fail with different
errors, including -EPROBE_DEFER. Instead of ignoring these errors and
potentially only print an error message, let's propagate them to give
callers the option to handle them.

Signed-off-by: Ulf Hansson <redacted>
Given that several patch series using ->attach_dev() are already floating
around and will be in -next soon, what is the plan of getting this in?
Shall we take this as a Reviewed-by or Acked-by for the series?  :)
No, I still have to review/test this series.

Changing ->attach_dev() to return an error code again is fine for me.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help