[PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
From: Kouei Abe <hidden>
Date: 2014-10-22 09:31:23
Also in:
linux-sh
Hi Uytterhoeven-san, Magnus-san, Simon-san, Kaneko-san, On Mon, 20 Oct 2014 02:53:37 +0200, Magnus Damm [off-list ref] wrote: | Hi Simon, | | On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman [off-list ref] wrote: | > On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote: | >> Hi Kaneko-san, Abe-san, | >> | >> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko [off-list ref] wrote: | >> > From: Kouei Abe [off-list ref] | >> | >> Thanks for your patches! | >> | >> > Signed-off-by: Kouei Abe [off-list ref] | >> > Signed-off-by: Yoshihiro Kaneko [off-list ref] | >> > --- | >> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++---- | >> > include/dt-bindings/clock/r8a7790-clock.h | 1 + | >> > 2 files changed, 6 insertions(+), 4 deletions(-) | >> > | >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi | >> > index 2380fd5..27c038c 100644 | >> > --- a/arch/arm/boot/dts/r8a7790.dtsi | >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi | >> | >> > clock-output-names = | >> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", | >> > - "vsp1-du0", "vsp1-rt", "vsp1-sy"; | >> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", | >> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; | >> | >> Why is this clock called "pvrsrvkm"? | >> The datasheet calls this clock "3DG". | > | > Good question. | > | > I am of two minds on how to handle this: | > | > 1. Simply change the name to 3dg (simple) | > 2. Seek clarification from Abe-san and his team | > | > Currently I am leaning to 1 as following the data-sheet feels like | > the right thing to do. | > | > Does anyone have an opinion on this? | | We are following the data sheet names everywhere else so I don't see | why this should be any exception. So my opinion is aligned with yours | - simply go with 1. above. | | Cheers, | | / magnus I confirmed that "pvrsrvkm" is 3DG driver's name. So, I will agree "Simply change the name to 3dg (simple)" plan. Kouei Abe