[PATCH v2 1/4] PM / Domains: Remove pm_genpd_dev_need_restore() API
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
Date: 2014-10-01 16:36:47
Also in:
linux-pm, linux-samsung-soc
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
Date: 2014-10-01 16:36:47
Also in:
linux-pm, linux-samsung-soc
On 01/10/14 16:41, Ulf Hansson wrote:
There are currently no users of this API, let's remove it.
The sad fact is that removal of pm_genpd_dev_need_restore() calls from arch/arm/mach-exynos/pm_domains.c introduces regressions in multiple exynos drivers (I'm sure it breaks media drivers). I think before doing such changes all relevant drivers should be updated first. I need to take a closer look again, but it seems after dropping the pm_genpd_dev_need_restore() calls, client driver's runtime_resume() callback is not being called in response to first pm_runtime_get(_sync) call, even if a device is runtime pm active. More details can be found in commit ebc35c726298ba3fdebba316a 'ARM: EXYNOS: register devices in 'need_restore' state for pm_domains'. The above only happens when devices are added to an inactive power domain, then I guess patch 2/4 is also an attempt to address this issue ? -- Thanks, Sylwester