Thread (4 messages) 4 messages, 2 authors, 2014-10-31

[RFC] arm:remove clear_thread_flag(TIF_UPROBE)

From: joe@perches.com (Joe Perches)
Date: 2014-10-31 07:58:15
Also in: linux-mm, lkml

On Fri, 2014-10-31 at 15:51 +0800, Wang, Yalin wrote:
quoted
From: Joe Perches [mailto:joe at perches.com]
quoted
diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
[]
quoted
@@ -591,10 +591,9 @@ do_work_pending(struct pt_regs *regs, unsigned int
thread_flags, int syscall)
quoted
 					return restart;
 				}
 				syscall = 0;
-			} else if (thread_flags & _TIF_UPROBE) {
-				clear_thread_flag(TIF_UPROBE);
+			} else if (thread_flags & _TIF_UPROBE)
 				uprobe_notify_resume(regs);
-			} else {
+			else {
 				clear_thread_flag(TIF_NOTIFY_RESUME);
 				tracehook_notify_resume(regs);
 			}
Please keep the braces.
mm..  could I know the reason ?  :)
Try read Documentation/CodingStyle

		Chapter 3: Placing Braces and Spaces

use braces in both branches:

if (condition) {
	do_this();
	do_that();
} else {
	otherwise();
}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help