On 25/10/14 20:42, Thomas Gleixner wrote:

On Sat, 25 Oct 2014, Thomas Gleixner wrote:

Bah, hit send way too fast :)

quoted

On Sat, 25 Oct 2014, Marc Zyngier wrote:

quoted

+int irq_get_irqchip_state(unsigned int irq, int state)

get_state(state) does not make sense. get_state(which) probably more
so. And 'which' wants to be an enum btw.

quoted

quoted

+	chip_bus_lock(desc);
+	val = chip->irq_get_irqchip_state(data, state);

Hmm. What's the irq_get_irqchip_state() callback supposed to return?

Either an error code or a boolean value, right? Does not mix very well
I think. 

int irq_get_irqchip_state(unsigned int irq, enum xxx which, bool *val)

Might be a more clear interface.

Agreed, this makes a lot of sense. Will respin it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...