Thread (11 messages) 11 messages, 4 authors, 2014-10-24

[STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional

From: peter.griffin@linaro.org (Peter Griffin)
Date: 2014-10-24 08:11:26
Also in: linux-media, lkml

Hi Srini,

Sorry seems I never replied to this.
quoted
quoted
drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer
from integer without a cast [enabled by default]
  rc_dev->rstc = reset_control_get(dev, NULL);
Is managing the reset line actually optional though? I can't test atm as I don't have
access to my board, but quite often if the IP's aren't taken out of reset reads / writes
to the perhpiheral will hang the SoC.
Yes and No.
AFAIK reset line is optional on SOCs like 7108, 7141.
I think having the driver function without reset might is a value
add in case we plan to reuse the mainline driver for these SOCs.
Yes that is a good point, for the series: -

Acked-by: Peter Griffin <peter.griffin@linaro.org>

regards,

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help