Thread (5 messages) 5 messages, 2 authors, 2014-10-23

[PATCH] tty: serial: omap: increase max consoles to 10

From: nm@ti.com (Nishanth Menon)
Date: 2014-10-22 12:25:16
Also in: linux-omap, linux-serial, lkml

On 10:03-20141022, Sebastian Andrzej Siewior wrote:
On 10/21/2014 06:23 PM, Nishanth Menon wrote:
quoted
The final solution is to transition off to use 8250 driver and no
dependency on console structures and move away from omap-serial driver,
hence no major cleanups are done for this driver.
So the shiny new driver works for you, is this what you are saying?
We have to complete our transition over to the new driver to see if we
have any behavior change. We will eventually get there.
quoted
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 18c30ca..4f9cbb6 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -46,7 +46,7 @@
 
 #include <dt-bindings/gpio/gpio.h>
 
-#define OMAP_MAX_HSUART_PORTS	6
+#define OMAP_MAX_HSUART_PORTS	10
 
 #define UART_BUILD_REVISION(x, y)	(((x) << 8) | (y))
Please also add a check in the probe code that "up->port.line" does not
exceed OMAP_MAX_HSUART_PORTS again. So we leave the probe function with
an error code instead.
Thanks. yeah - that is a pretty good idea. Will do the same for v2.

-- 
Regards,
Nishanth Menon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help