On 22 October 2014 10:07, Geert Uytterhoeven [off-list ref] wrote:

On Wed, Oct 22, 2014 at 9:58 AM, Ulf Hansson [off-list ref] wrote:

quoted

Now, I just realized that while Geert added attach|detach_dev()
callbacks for the generic PM domain, those are both "void" callbacks.
It means the deferred probe error handling is broken for these
callbacks. We should convert the attach_dev() callback into an int, I
will cook a patch immediately.

That was changed in v3:
  - Move calling of the callbacks to a point where dev->pm_domain is
    valid, so the domain parameter is no longer needed,

That's good.

  - Make callbacks return void.

But not this. :-) Sorry, for being too quick in reviewing that time.

Kind regards
Uffe