Thread (28 messages) 28 messages, 4 authors, 2014-11-24

[PATCH v7 5/7] sched: get CPU's usage statistic

From: vincent.guittot@linaro.org (Vincent Guittot)
Date: 2014-10-10 14:38:32
Also in: lkml

On 9 October 2014 17:12, Peter Zijlstra [off-list ref] wrote:
quoted
quoted
quoted
+static int get_cpu_usage(int cpu)
+{
+     unsigned long usage = cpu_rq(cpu)->cfs.utilization_load_avg;
+     unsigned long capacity = capacity_orig_of(cpu);
+
+     if (usage >= SCHED_LOAD_SCALE)
+             return capacity + 1;
Like Morten I'm confused by that +1 thing.
ok. the goal was to point out the erroneous case where usage is out of
the range but if it generates confusion, it can remove it
Well, the fact that you clip makes that point, returning a value outside
of the specified range doesn't.
i meant removing the +1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help