Thread (17 messages) 17 messages, 4 authors, 2014-10-22
STALE4240d

[PATCH v2 5/5] m25p80,spi-nor: Share the list of supported chip type names again

From: zajec5@gmail.com (Rafał Miłecki)
Date: 2014-09-30 08:02:25

On 30 September 2014 04:15, Ben Hutchings [off-list ref] wrote:
Move the list of chip type information to a macro in spi-nor.h, but
leave the definitions of INFO and CAT25_INFO in spi-nor.

In m25p80, define the INFO and CAT25_INFO macros to initialise a
struct spi_device_id with the name, ignoring the remaining parameters.
Anyone would consider my idea proposed in 1/5 thread?

We could simply follow the way Linux-specific platform data works. We
could always use
compatible = "m25p80";
and then for some rare cases (where JEDEC fails) add something like
model = "at25df321a";

Using above way we could use a one single "compatible" in m25p80.c and
avoid this messy share of id_table.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help