[PATCH v4 2/8] clk: samsung: Factor out the common code to clk.c
From: Tomasz Figa <hidden>
Date: 2014-09-13 11:20:12
Also in:
linux-devicetree, linux-samsung-soc
Hi Naveen, Please see my comments inline. On 12.09.2014 17:26, Naveen Krishna Chatradhi wrote:
While adding clock support for Exynos5260, the infrastructure to register multiple clock controllers was introduced. Factor out the support for registering multiple clock controller from Exynos5260 clock code to common samsung clock code so that it can be used by other Exynos SoC which have multiple clock controllers.
[snip]
quoted hunk ↗ jump to hunk
@@ -268,7 +135,7 @@ struct samsung_gate_clock aud_gate_clks[] __initdata = { static void __init exynos5260_clk_aud_init(struct device_node *np) { - struct exynos5260_cmu_info cmu = {0}; + struct exynos_cmu_info cmu = {0}; cmu.mux_clks = aud_mux_clks; cmu.nr_mux_clks = ARRAY_SIZE(aud_mux_clks);@@ -280,7 +147,7 @@ static void __init exynos5260_clk_aud_init(struct device_node *np) cmu.clk_regs = aud_clk_regs; cmu.nr_clk_regs = ARRAY_SIZE(aud_clk_regs); - exynos5260_cmu_register_one(np, &cmu); + exynos_cmu_register_one(np, &cmu);
I'd suggest changing the namespace prefix from exynos to just samsung to be consistent with other helpers. Otherwise looks good. Best regards, Tomasz