Thread (11 messages) 11 messages, 3 authors, 2014-10-08

[PATCH v7 3/5] ARM: dts: add RK3xxx CPU Thermal data

From: dianders@chromium.org (Doug Anderson)
Date: 2014-09-30 18:24:32
Also in: linux-devicetree, linux-pm, lkml

Caesar,

On Sun, Sep 28, 2014 at 3:38 AM, Caesar Wang [off-list ref] wrote:
This patch changes a dtsi file to contain the thermal data
on RK3288 and later SoCs. This data will
enable a thermal shutdown over 125C.

Signed-off-by: Caesar Wang <redacted>
---
 arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi | 32 +++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi
I haven't done lots of review of this series, but I did notice that
this file has bad spacing.  It's fairly obvious in your gerrit patch
<https://chromium-review.googlesource.com/#/c/220270/1/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi>
because gerrit (by default) shows you "tab" characters...

In general you should use tab for indentation, not spaces.  You seem
to use a mix of the two.

-Doug
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help