On Tue, Sep 30, 2014 at 3:09 PM, David Laight [off-list ref] wrote:

quoted

quoted

+static inline int gbe_phy_link_status(struct gbe_slave *slave)
+{
+   if (!slave->phy)
+           return 1;
+
+   if (slave->phy->link)
+           return 1;
+
+   return 0;
+}

Please use 'bool' as the return type and return 'true' or 'false'.

That function body could also be just:
        return !slave->phy && slave->phy->link;
which might be more readable if directly coded.

return !slave->phy || slave->phy->link;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds