On 09/29/2014 03:43 PM, Wolfram Sang wrote:

quoted

quoted

+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Error checking on *res*...?

We should *return* on platform_get_resource() failure..

quoted

+	base = devm_ioremap_resource(&pdev->dev, res);

Nope. devm_ioremap_resource does that.

Yes it will [1]. Thanks for the clarification.

[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117

-- 
Regards,
Varka Bhadram.