On Fri, Sep 26, 2014 at 09:51:53PM +0100, Russell King - ARM Linux wrote:

On Fri, Sep 26, 2014 at 01:02:01PM +0100, Russell King - ARM Linux wrote:

quoted

On Fri, Sep 26, 2014 at 07:25:02PM +0800, Chenhui Zhao wrote:

quoted

+void fsm_write32(void __iomem *addr, u32 val)
+{
+#ifdef __arm__
+	iowrite32be(val, addr);
+#endif
+
+#ifdef __powerpc__
+	out_be32(addr, val);
+#endif

The idea of iowrite* is that it should be able to address MMIO or IO
memory irrespective of the platform.  Why is PowerPC not implementing
this accessor, or why can't it be used for PowerPC?

This should just use iowrite32be(), and if it doesn't work on PowerPC,
PowerPC needs to be fixed.

BenH tells me that this should be able to use iowrite32be() on PowerPC
too without problems, there should be no need to use the older out_be32()
accessors here.  Please can you look into using only iowrite32be() here?

Thanks.

Thanks. I'll fix it.

Chenhui