Thread (1 message) 1 message, 1 author, 2014-09-26

[PATCH v3 3/4] irq: Allow multiple clients to register for irq affinity notification

From: khilman@kernel.org (Kevin Hilman)
Date: 2014-09-26 15:10:13
Also in: linux-pm, lkml

Russell King - ARM Linux [off-list ref] writes:
On Fri, Sep 26, 2014 at 11:29:56AM +0200, Thomas Gleixner wrote:
quoted
On Thu, 25 Sep 2014, Kevin Hilman wrote:
quoted
Maybe I'm missing something, or maybe we're just lucky and nobody uses
them together, but irq_set_affinity_notifier() only allows a single
notifier to be registered at any given time.  So if you had a system
A single notifier per irq .....
So what about two drivers wanting to use this notifier, but sharing an
interrupt?

It sounds to me like this notifier was misdesigned from the very start,
and it should always have supported multiple notifiers.
I agree.

$SUBJECT patch tries to add that support, and is part of a series
wanting to use these notifiers in the PM QoS subsystem, while at the
same time not breaking existing users.

I suppose this series could be written without $SUBJECT patch, and
crossing fingers in the hopes that an existing user of the notifiers
doesn't also need to use the pm_qos constraints, but that seems like
knowingly leaving an armed landmine laying around.

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help