Thread (9 messages) 9 messages, 4 authors, 2014-10-09

[PATCH resend] arm:extend the reserved memory for initrd to be page aligned

From: Wang, Yalin <hidden>
Date: 2014-09-26 01:56:51
Also in: linux-arm-msm, linux-mm, lkml

quoted hunk ↗ jump to hunk
On Fri, Sep 19, 2014 at 11:00:02AM +0100, Catalin Marinas wrote:
quoted
On Fri, Sep 19, 2014 at 08:09:47AM +0100, Wang, Yalin wrote:
quoted
this patch extend the start and end address of initrd to be page
aligned, so that we can free all memory including the un-page
aligned head or tail page of initrd, if the start or end address of
initrd are not page aligned, the page can't be freed by
free_initrd_mem() function.
quoted
quoted
Signed-off-by: Yalin Wang <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>

(as I said, if Russell doesn't have any objections please send the
patch to his patch system)
I now have an objection.  The patches in the emails were properly formatted.
The patches which were submitted to the patch system (there's two of them
doing the same thing...) are not:
--- ../kernel.torvalds.git.origin/arch/arm/mm/init.c    2014-09-24
16:24:06.863759000 +0800
+++ arch/arm/mm/init.c  2014-09-24 16:27:11.455456000 +0800
This is totally broken.  Let's read the patch(1) man page:

       First, patch takes an ordered list of candidate file names as
follows:

        ? If the header is that of a context diff, patch takes the old and
new
          file  names  in  the  header.  A name is ignored if it does not
have
          enough slashes to satisfy the -pnum or --strip=num option.  The
name
          /dev/null is also ignored.

        ? If  there is an Index: line in the leading garbage and if either
the
          old and new names are both absent  or  if  patch  is  conforming
to
          POSIX, patch takes the name in the Index: line.

        ? For the purpose of the following rules, the candidate file names
are
          considered to be in the order (old, new, index), regardless  of
the
          order that they appear in the header.

       Then patch selects a file name from the candidate list as follows:

        ? If  some  of  the named files exist, patch selects the first name
if
          conforming to POSIX, and the best name otherwise.
...
        ? If no named files exist, no RCS, ClearCase, Perforce, or SCCS
master
          was found, some names are given, patch is not conforming  to
POSIX,
          and  the patch appears to create a file, patch selects the best
name
          requiring the creation of the fewest directories.

        ? If no file name results from the above heuristics, you are asked
for
          the name of the file to patch, and patch selects that name.

...

NOTES FOR PATCH SENDERS
       There are several things you should bear in mind if you are going to
be
       sending out patches.
...
       If the recipient is supposed to use the -pN option, do not send
output
       that looks like this:

          diff -Naur v2.0.29/prog/README prog/README
          --- v2.0.29/prog/README   Mon Mar 10 15:13:12 1997
          +++ prog/README   Mon Mar 17 14:58:22 1997

       because  the two file names have different numbers of slashes, and
dif-
       ferent versions of patch interpret  the  file  names  differently.
To
       avoid confusion, send output that looks like this instead:

          diff -Naur v2.0.29/prog/README v2.0.30/prog/README
          --- v2.0.29/prog/README   Mon Mar 10 15:13:12 1997
          +++ v2.0.30/prog/README   Mon Mar 17 14:58:22 1997
Got it ,
I will resend the patch,
By the way, how to remove my wrong patch in the patch system ?

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help