Thread (15 messages) 15 messages, 2 authors, 2014-09-24

[PATCH 3/4] gpio: vf610: add gpiolib/IRQ chip driver for Vybird

From: Linus Walleij <hidden>
Date: 2014-09-24 11:10:37
Also in: linux-gpio, lkml

On Tue, Sep 23, 2014 at 1:51 PM, Stefan Agner [off-list ref] wrote:
[Me]
quoted
postcore again. I don't like this, can you get rid of it?
I guess we could load this driver easily a bit later. IMHO, since lots
of other driver use GPIO's, we should it load before all the drivers
gets loaded (before device_initcall).
Nope. We use deferred probing to control that today. Ideally
all drivers should be device_initcall() and deferred probe be used
to order things, not by playing around with initcalls.
Most GPIO driver do this, some statistic again:
$ grep -h -o ".*_initcall" drivers/gpio/*.c | sort | uniq -c | sort -n
-r
     33 subsys_initcall
     14 postcore_initcall
      2 device_initcall
      2 arch_initcall
      1 late_initcall
      1 core_initcall
Yeah old legacy. There are patch attacks to get rid of this.

The reason we can't just change them is because sometimes
dependent drivers do not handle the errorpath very well can can't
defer cleanly.

With a new driver I expect deferred probe to be used.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help