Thread (26 messages) 26 messages, 3 authors, 2014-09-23

[PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller

From: Antoine Tenart <hidden>
Date: 2014-09-23 14:30:49
Also in: linux-devicetree, lkml, netdev

On Tue, Sep 23, 2014 at 04:01:13PM +0200, Antoine Tenart wrote:
Arnd,

On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote:
quoted
On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote:
quoted
+Optional properties:
+- port-id: should be '0','1' or '2'.
+- phy-addr: MDIO address of the PHY.
+- local-mac-address: see ethernet.txt file in the same directory.
+
I believe new bindings should not use "phy-addr" properties, but
instead use a phy-handle property pointing to a phy device instead.
So I had a look on other Ethernet bindings. Would you agree with
something like the following?

	eth0: ethernet at f7b90000 {
		...
		#address-cells = <1>;
		#size-cells = <0>;
		phy-handle = <&ethphy0>;

		ethphy0: ethernet-phy at 0 {
			reg = <0>;
		};
	};

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help