[PATCH 2/4] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135.

2014-09-19 15:47 GMT+02:00 Joe.C [off-list ref]:

On Fri, 2014-09-19 at 19:48 +0800, srv_hongzhou.yang at mediatek.com wrote:

quoted

+
+static const struct pinmux_ops mt_pmx_ops = {
+     .get_functions_count    = mt_pmx_get_funcs_cnt,
+     .get_function_name      = mt_pmx_get_func_name,
+     .get_function_groups    = mt_pmx_get_func_groups,
+     .enable                 = mt_pmx_enable,
+     .disable                = mt_pmx_disable,
+     .gpio_set_direction     = mt_pmx_gpio_set_direction,
+};
+

It seems pinmux_ops.disable is removed in commit commit
2243a87d90b42eb38bc281957df3e57c712b5e56. So this will cause build
error. This should be fixed in next version.

For this cases and in general it would be good to put in the patch set
description against which tree/tag the patches are build.

Thanks,
Matthias

../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: error: unknown
field 'disable' specified in initializer
../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: warning:
initialization from incompatible pointer type [enabled by default]
../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: warning: (near
initialization for 'mt_pmx_ops.gpio_request_enable') [enabled by
default]

Joe.C

-- 
motzblog.wordpress.com