On 15/09/14 22:47, Daniel Thompson wrote:

On 15/09/14 17:34, Paul Bolle wrote:

quoted

On Tue, 2014-08-19 at 15:48 +0100, Daniel Thompson wrote:

quoted

As part of the migration we introduce DEBUG_UART_PHYS/DEBUG_UART_VIRT
which default to UART1 but allow a user to configure UART2 or UART3.
We also introduce symbolic names for the registers and flags.

Signed-off-by: Daniel Thompson <redacted>
Cc: Russell King <redacted>
Acked-by: Arnd Bergmann <redacted>
Cc: linux-arm-kernel at lists.infradead.org

This patch landed in today's linux-next, as 880fa9b6fd73 ("ARM: 8144/1:
netx: Migrate DEBUG_LL macros to shared directory").

quoted

[...]

--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug

@@ -447,6 +447,14 @@ choice
 		  Say Y here if you want kernel low-level debugging support
 		  on Vybrid based platforms.
 
+	config DEBUG_NETX_UART
+		bool "Kernel low-level debugging messages via NetX UART"
+		depends on ARCH_NETX
+		select DEBUG_UART_NETX

There's no Kconfig symbol DEBUG_UART_NETX in next-20140915. So in
linux-next this is currently a nop. Is this symbol queued somewhere?

No. The symbol isn't queued anywhere.

DEBUG_UART_NETX is a config value that existed transiently when I wrote
the patch and I didn't clean it up properly. I suspect its visual
similarity to DEBUG_NETX_UART means it didn't jump out when I self reviewed.

Thanks for raising this. I will share a patch to remove this.

I was just finalizing this and, since it was on my screen anyway, took
another look at my assembler changes.

They are broken! Rather than initializing \rp and \rv as they are
supposed to they set \rp to two different values leaving \rv uninitialized.

This I will also fix.


Daniel.