Thread (7 messages) flat view 7 messages, 4 authors, 2014-09-16

[PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-09-05 18:34:48
Also in: linux-pci, lkml

On Friday 05 September 2014 20:20:44 Thomas Petazzoni wrote:
Hum, I think I would actually prefer something like:

                if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
                        rtype = IORESOURCE_IO;
                else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
                        rtype = IORESOURCE_MEM;
+               else
+                       continue;

So that we're explicit with the fact that we only care about I/O and
MEM32 resource types.
Agreed, that looks better than my patch as well.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help