Thread (37 messages) 37 messages, 11 authors, 2014-09-15

[Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-09-01 15:19:15
Also in: linux-acpi, lkml

On Monday 01 September 2014 23:06:00 Hanjun Guo wrote:
+#ifdef CONFIG_ACPI
+/* Configure some sensible defaults for ACPI mode */
+static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config,
+                                   acpi_handle *ahandle)
+{
+       if (!ahandle)
+               return -ENOSYS;
+
+       config->phy_interface = PHY_INTERFACE_MODE_MII;
Please remove the #ifdef and use 

	if (!IS_ENABLED(CONFIG_ACPI) || !ahandle)

to check for ACPI support. This should result in the same object code
in all cases, but give better compile-time coverage when ACPI is
disabled.

Also, -ENOSYS is probably the wrong return value. I think you mean
-ENXIO.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help