Thread (31 messages) 31 messages, 6 authors, 2014-08-29
STALE4316d
Revisions (6)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 current
  5. v1 [diff vs current]
  6. v1 [diff vs current]

[PATCH 2/9] arm64: Fix INVALID_HWID definition

From: geoff@infradead.org (Geoff Levand)
Date: 2014-08-26 17:38:17

Hi Mark,

On Tue, 2014-08-26 at 17:31 +0100, Mark Rutland wrote:
On Fri, Aug 22, 2014 at 08:49:16PM +0100, Geoff Levand wrote:
quoted
Change the preprocessor macro INVALID_HWID definition from ULONG_MAX to (~0)
to allow INVALID_HWID to be used within assembly source files.

Commit 3e98fdacc59bbbdbb659be1a144ccc48ed4860fa (arm64: kernel: make the pen of
the secondary a 64-bit unsigned value) added the preprocessor macro INVALID_HWID
to asm/cputype.h with it defined to be ULONG_MAX.  Use of INVALID_HWID in an
assembly source file that includes cputype.h will generate an assembler
undefined symbol ULONG_MAX build error.  The kernel does define a ULONG_MAX in
kernel.h, but that file not setup to be included in assembly files.
We don't seem to be using INVALID_HWID in any assembly at the moment,
and I'm not sure I follow what we'd need it for.

Why do we need this in assembly?
We currently don't use INVALID_HWID in any assembly files, but I wanted
to use it for some testing and found the current definition gave an
error.

-Geoff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help