[PATCH 1/6] ARM: dts: microsom-ar8035: MDIO pad must be set open drain

On Sun, Aug 24, 2014 at 10:44:54AM +0100, Iain Paton wrote:

On 23/08/14 10:11, Russell King wrote:

quoted

From: Rabeeh Khoury <redacted>
To: Shawn Guo <redacted>

MDIO pad must be set open drain.

Signed-off-by: Rabeeh Khoury <redacted>
Signed-off-by: Russell King <redacted>
---
 arch/arm/boot/dts/imx6qdl-microsom-ar8035.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-microsom-ar8035.dtsi b/arch/arm/boot/dts/imx6qdl-microsom-ar8035.dtsi
index d16066608e21..db9f45b2c573 100644
--- a/arch/arm/boot/dts/imx6qdl-microsom-ar8035.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-microsom-ar8035.dtsi

@@ -17,7 +17,7 @@
 	enet {
 		pinctrl_microsom_enet_ar8035: microsom-enet-ar8035 {
 			fsl,pins = <
-				MX6QDL_PAD_ENET_MDIO__ENET_MDIO		0x1b0b0
+				MX6QDL_PAD_ENET_MDIO__ENET_MDIO		0x1b8b0
 				MX6QDL_PAD_ENET_MDC__ENET_MDC		0x1b0b0
 				/* AR8035 reset */
 				MX6QDL_PAD_KEY_ROW4__GPIO4_IO15		0x130b0

Can you elaborate some more on the reasons for this?  

I'd like to understand if it's something specific to the hardware on that 
board, or if other i.MX6 boards using the ar8035 are doing it wrong as well.

The datasheet strongly suggests this is the correct thing to do as MDIO 
should electrically be open drain. However that suggests many more instances 
of this incorrect configuration exist which also need changed, and not just 
for ar8035.

While I'm reluctant to attribute something like this to the fec/interrupt 
problems some people are seeing, I'd also like to be able to rule it out.

I'm merely passing the patch along; I've forwarded your question to
Rabeeh via IRC, and may have an answer soon.

FYI, I've run for a long time (close to a year now) on various iMX6
SolidRun platforms without the above patch and haven't seen a problem.
I've now also running with it on Solo and Quad and haven't seen any
ill effects there, despite the machines running root-NFS, doing
regular compiles and git activity.

For me, the problem device right now is that placing the Vivante 2D
GPU under stress (using gtkperf) causes the pixel engines to lock up.
The Solo is extremely unstable, locking up in less than a second on
the first or second test, whereas the Quad is much better, normally
taking two runs before locking up in the circle drawing.  The Solo
also locks up the 2D pixel engines if it needs ot resize the display
(due to HDMI being connected.)

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.