Thread (21 messages) 21 messages, 5 authors, 2014-08-11
STALE4358d REVIEWED: 4 (4M)

[PATCH 1/6] ARM: mvebu: Add required ethernet muxing for the Armada 370 SoC

From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
Date: 2014-08-10 12:16:32

On 08/08/2014 05:18 PM, Ezequiel Garcia wrote:
quoted hunk ↗ jump to hunk
This commit adds the required pin muxing for the two network interfaces
and the MDIO interface, to the Armada 370 SoC.

Signed-off-by: Ezequiel Garcia <redacted>
---
 arch/arm/boot/dts/armada-370.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
index 21b588b..b0700bf6 100644
--- a/arch/arm/boot/dts/armada-370.dtsi
+++ b/arch/arm/boot/dts/armada-370.dtsi
@@ -151,6 +151,25 @@
 						       "mpp62", "mpp60", "mpp58";
 					marvell,function = "audio";
 				};
+
+				mdio_pins: mdio_pins {
Ezequiel,

please keep me posted next time ;)

Above should be: mdio_pins: mdio-pins {
same for the ones below.
+					marvell,pins = "mpp17", "mpp18";
+					marvell,function = "ge";
As we haven't used it before, we could still rename "ge" function to
more approprate "mdio"... but it is ok.

Besides the comments,

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
+				};
+
+				ge0_pins: ge0_pins {
+					marvell,pins = "mpp5", "mpp6", "mpp7", "mpp8",
+						       "mpp9", "mpp10", "mpp11", "mpp12",
+						       "mpp13", "mpp14", "mpp15", "mpp16";
+					marvell,function = "ge0";
+				};
+
+				ge1_pins: ge1_pins {
+					marvell,pins = "mpp19", "mpp20", "mpp21", "mpp22",
+						       "mpp23", "mpp24", "mpp25", "mpp26",
+						       "mpp27", "mpp28", "mpp29", "mpp30";
+					marvell,function = "ge1";
+				};
 			};
 
 			gpio0: gpio at 18100 {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help