Thread (18 messages) 18 messages, 5 authors, 2014-09-04

[PATCH v5 1/3] ARM: probes: check stack operation when decoding

From: Will Deacon <hidden>
Date: 2014-08-28 10:24:45
Also in: lkml

On Thu, Aug 28, 2014 at 11:20:21AM +0100, Russell King - ARM Linux wrote:
On Thu, Aug 28, 2014 at 06:51:15PM +0900, Masami Hiramatsu wrote:
quoted
(2014/08/27 22:02), Wang Nan wrote:
quoted
This patch improves arm instruction decoder, allows it check whether an
instruction is a stack store operation. This information is important
for kprobe optimization.

For normal str instruction, this patch add a series of _SP_STACK
register indicator in the decoder to test the base and offset register
in ldr <Rt>, [<Rn>, <Rm>] against sp.

For stm instruction, it check sp register in instruction specific
decoder.
OK, reviewed. but since I'm not so sure about arm32 ISA,
I need help from ARM32 maintainer to ack this.
What you actually need is an ack from the ARM kprobes people who
understand this code.  That would be much more meaningful than my
ack.  They're already on the Cc list.
Tixy, can you take a look please?

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help