Thread (1 message) 1 message, 1 author, 2014-08-27

[PATCH V2 4/7] ARM: OMAP2+: powerdomain: introduce logic for finding valid power domain

From: Kevin Hilman <hidden>
Date: 2014-08-27 20:25:47
Also in: linux-omap, lkml

Nishanth Menon [off-list ref] writes:
powerdomain configuration in OMAP is done using PWRSTCTRL register for
each power domain. However, PRCM lets us write any value we'd like to
the logic and power domain target states, however the SoC integration
tends to actually function only at a few discrete states. These valid
states are already in our powerdomains_xxx_data.c file.

So, provide a function to easily query valid low power state that the
power domain is allowed to go to.

Based on work originally done by Jean Pihet [off-list ref]
https://patchwork.kernel.org/patch/1325091/ . There is no attempt to
create a new powerdomain solution here, except fixing issues seen
attempting invalid programming attempts. Future consolidation to the
generic powerdomain framework should consider this requirement as
well.

Similar solutions have been done in product kernels in the past such
as:
https://android.googlesource.com/kernel/omap.git/+blame/android-omap-panda-3.0/arch/arm/mach-omap2/pm44xx.c

Reviewed-by: Kevin Hilman <redacted>
Acked-by: Santosh Shilimkar <redacted>
Signed-off-by: Nishanth Menon <nm@ti.com>
---

Not posting the entire series again and updating just this patch..

V2: drop BUG in favor of WARN, picked up Santosh and Kevin's acks.
Looks good, thanks,

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help