On 08/21/2014 10:04 AM, Eduardo Valentin wrote:

Stephen,

On Wed, Aug 20, 2014 at 01:44:00PM -0600, Stephen Warren wrote:

quoted

On 08/06/2014 04:25 AM, Mikko Perttunen wrote:

quoted

This adds critical trip points to the Jetson TK1 device tree.
The device will do a controlled shutdown when either the CPU, GPU
or MEM thermal zone reaches 101 degrees Celsius.

quoted

diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts

quoted

+	thermal-zones {
+		cpu {
+			trips {

...

quoted

+			};
+		};

thermal.txt states that a cooling-maps sub-node is mandatory. However,
it seems to be missing here. Is the DT binding documentation overly
strict, or do we need to add such a node here?

I believe the binding documentation is correct. I believe this driver
should still evolve a little bit to accomplish full thermal DT
description and include the cooling devices mapping.

All the best,

Should we hold off applying the Tegra DT until we can actually fill in 
the cooling aspects, or are you OK with an empty cooling node as Mikko 
suggested?