Hi Felipe,

On Thu, 21 Aug 2014, Felipe Balbi wrote:

quoted

Currently (in the vendor tree) one of the phys lives in
drivers/usb/phy and the other in drivers/phy.
I believe that is because one is only a usb phy and the other is a
multi function phy which can drive PCI-E or USB3.

right, but for mainline, we can have both PHYs in drivers/phy only.

Ah ok, I didn't know that, so thanks for that info.

quoted

So to make that work, when dwc3/core.c gets the PHYS in
dwc3_core_get_phy() we need to use the different bindings.

I think we are the only platform using "one of each", but luckily
dwc3_core_get_phy() has been written generically enough that it "just
works" :-).

true, but I want to drop support for the legacy drivers/usb/phy layer
from dwc3. I'll try to move all PHYs to drivers/phy for v3.18.

Ok, so for the next re-spin I will change this to just use the generic phy binding
for both usb2 & usb3 phys.

In parallel I will also migrate over the drivers/usb/phy driver to be just a generic phy
before I attempt to upstream it.

regards,

Peter