Thread (11 messages) flat view 11 messages, 4 authors, 2014-08-21

[PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288

From: dianders@chromium.org (Doug Anderson)
Date: 2014-08-20 19:31:20
Also in: linux-devicetree, linux-pwm, lkml

Dmitry,

On Wed, Aug 20, 2014 at 12:29 PM, Dmitry Torokhov
[off-list ref] wrote:
On August 20, 2014 1:54:11 PM CDT, Doug Anderson [off-list ref] wrote:
quoted
On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding
[off-list ref] wrote:
quoted
On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote:
quoted
The rk3288 has the ability to invert
+     struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
+
+     if (!pc->data->has_invert)
+             return -ENOSYS;
+
At the kernel summit hpa also mentioned that ENOSYS should only be used for missing syscalls. Not sure what error code would suit better here though...
Luckily this code is gone now.  See v4 of the series.  ;)

-Doug
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help