Thread (2 messages) 2 messages, 2 authors, 2014-08-18

[PATCH] cpufreq: exynos: free memory immediately on unknown SoC

From: viresh.kumar@linaro.org (Viresh Kumar)
Date: 2014-08-18 07:59:56
Also in: linux-pm, linux-samsung-soc, lkml

On 17 August 2014 09:36, Arjun Sreedharan [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Arjun Sreedharan <redacted>
---
 drivers/cpufreq/exynos-cpufreq.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 1e0ec57..e47d165 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
                ret = exynos5250_cpufreq_init(exynos_info);
        } else {
                pr_err("%s: Unknown SoC type\n", __func__);
+               kfree(exynos_info);
                return -ENODEV;
        }
Apart from the fact that we could have added some logs and improved
$subject a bit,
it looks fine.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help