[PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently
From: peter.griffin@linaro.org (Peter Griffin)
Date: 2014-08-15 12:52:14
Also in:
linux-mmc, lkml
From: peter.griffin@linaro.org (Peter Griffin)
Date: 2014-08-15 12:52:14
Also in:
linux-mmc, lkml
Hi Russell,
quoted
This happened in commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function") commit a702c8abb2a9 ("mmc: host: split up sdhci-pxa, create sdhci-pxav3.c")'This is exactly why named initialisers should always follow the declaration order in the structure definition. It also helps avoid git merge to properly resolve two additions of the same member (possibly with a conflict) rather than just adding both.
Ah yes that makes a lot of sense. I will send a V2 in a moment, as the line I removed now means that it's not in order with the structure definition. regards, Peter.