[PATCH 6/6] tty: serial: Add 8250-core based omap driver
From: heikki.krogerus@linux.intel.com (Heikki Krogerus)
Date: 2014-08-08 11:05:46
Also in:
linux-omap, linux-serial, lkml
On Wed, Jul 09, 2014 at 07:49:37PM +0200, Sebastian Andrzej Siewior wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index bf06a4c..1cbfc8c 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c@@ -263,6 +263,12 @@ static const struct serial8250_config uart_config[] = { .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, .flags = UART_CAP_FIFO | UART_CAP_AFE, }, + [PORT_OMAP_16750] = { + .name = "OMAP", + .fifo_size = 64, + .tx_loadsz = 64, + .flags = UART_CAP_FIFO | UART_CAP_EFR | UART_CAP_SLEEP, + }, [PORT_TEGRA] = { .name = "Tegra", .fifo_size = 32,@@ -1340,6 +1346,8 @@ static void serial8250_stop_rx(struct uart_port *port) pm_runtime_get_sync(port->dev); up->ier &= ~UART_IER_RLSI; + if (port->type == PORT_OMAP_16750) + up->ier &= ~UART_IER_RDI; up->port.read_status_mask &= ~UART_LSR_DR; serial_port_out(port, UART_IER, up->ier);
Alan couldn't UART_IER_RDI be always cleared here with all port types? Actually, shouldn't it be? Then the custom port type PORT_OMAP_16750 would not be needed. -- heikki