[PATCH 12/14] ll_temac: delete unneeded test before of_node_put
From: Michal Simek <hidden>
Date: 2014-08-08 10:45:31
Also in:
kernel-janitors, lkml, netdev
On 08/08/2014 12:07 PM, Julia Lawall wrote:
quoted hunk ↗ jump to hunk
From: Julia Lawall <redacted> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-K?nig. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e; @@ -if (e) of_node_put(e); // </smpl> Signed-off-by: Julia Lawall <redacted> --- drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 8a6e5c2..36f4459 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c@@ -1148,8 +1148,7 @@ static int temac_of_remove(struct platform_device *op) temac_mdio_teardown(lp); unregister_netdev(ndev); sysfs_remove_group(&lp->dev->kobj, &temac_attr_group); - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); lp->phy_node = NULL; iounmap(lp->regs); if (lp->sdma_regs)
Reviewed-by: Michal Simek <redacted> Thanks, Michal