On 31 July 2014 18:15, Leif Lindholm [off-list ref] wrote:

On Thu, Jul 31, 2014 at 04:53:38PM +0100, Will Deacon wrote:

quoted

quoted

quoted

quoted

     The patch works well on FVP model, and here are the boot log and
dmidecode+lshw result:

Thanks Yi!

Can we help Will out if he wants to test this himself?

     @Will: which platform do you have on hand?  I am using FVP model
for testing.
     First, you need to merge SMBIOS support into UEFI.
     Then, compile and install the dmidecode(open source) on the linux
,and run it.

I've got some stuff from Leif for testing this, but what I'm really after is
something that would have spotted this problem. Are there any compliance
tests, for example?

The patch as previously submitted (and accepted) was functional on all
platforms it has been tested on. It is technically not compliant with
the UEFI specification, but it works with the images we had.
The worst-case failure would have been the lookup function returning
NULL and the SMBIOS tables being unavailable even though they existed.

Indeed. It would be bad for us to rely on non-compliant but wide
spread behavior, so I think it is a good thing to shake out these bugs
now, even if they haven't caused any problems.

What you are asking for would be a test for UEFI, not for the kernel.
(And this one might be useful to add to the fwts if it's not already
part of it.)

Yes, it would be good if we could test for patterns like this, (i.e.,
config tables with EFI_MEMORY_RUNTIME set).